Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-20.0] Upgrade the Golang version to go1.22.5 #16323

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[release-20.0] Upgrade the Golang version to go1.22.5 #16323

merged 2 commits into from
Jul 3, 2024

Conversation

vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot commented Jul 2, 2024 •
edited by frouioui
Loading

This Pull Request bumps the Golang version to go1.22.5 and the bootstrap version to 32.1.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.22.5

cc @vitessio/release

@vitess-bot vitess-bot added the Benchmark me Add label to PR to run benchmarks label Jul 2, 2024
@vitess-bot vitess-bot added Component: General Changes throughout the code base go labels Jul 2, 2024
@vitess-bot vitess-bot requested a review from frouioui as a code owner July 2, 2024 21:48
@vitess-bot vitess-bot added Skip CI Skip CI actions from running Type: CI/Build labels Jul 2, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 2, 2024

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot vitess-bot requested a review from a team July 2, 2024 21:48
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 2, 2024
@github-actions github-actions bot added this to the v20.0.1 milestone Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (3d14b31) to head (fc40fb9).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-20.0   #16323      +/-   ##
================================================
+ Coverage         68.65%   68.67%   +0.01%     
================================================
  Files              1541     1541              
  Lines            197830   197830              
================================================
+ Hits             135826   135861      +35     
+ Misses            62004    61969      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui removed Skip CI Skip CI actions from running NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 2, 2024
@frouioui frouioui force-pushed the upgrade-go-to-1.22.5-on-release-20.0 branch from 0360ed7 to b3b9f8d Compare July 2, 2024 23:06
@frouioui
Copy link
Member

frouioui commented Jul 2, 2024

The new Go docker images are not available yet (https://hub.docker.com/_/golang/tags?page=&page_size=&ordering=&name=1.22.5), I have not built and pushed the bootstrap image.

@frouioui frouioui force-pushed the upgrade-go-to-1.22.5-on-release-20.0 branch from b3b9f8d to 519bd30 Compare July 3, 2024 14:34
@frouioui frouioui force-pushed the upgrade-go-to-1.22.5-on-release-20.0 branch from 519bd30 to f60c1b4 Compare July 3, 2024 19:25
frouioui and others added 2 commits July 3, 2024 15:40
@frouioui
bump go version to go1.22.5
75d0109 
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Update workflows and go.mod to 1.22.5
fc40fb9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-go-to-1.22.5-on-release-20.0 branch from f60c1b4 to fc40fb9 Compare July 3, 2024 19:40
@frouioui frouioui merged commit e25e5e1 into release-20.0 Jul 3, 2024
181 checks passed
@frouioui frouioui deleted the upgrade-go-to-1.22.5-on-release-20.0 branch July 3, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Milestone
v20.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vitess-bot @frouioui @mattlord